Drop deprecated DifferentiableQoI::init_qoi() #4318
Merged
+0
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This virtual keyword on this function was deprecated in 6fbd01f (2022), so it has been deprecated since the 1.8.x release series. The non-deprecated, non-virtual version of the function was made into a no-op. Therefore, there may be code which still calls this function, but it would just be doing nothing, so let's try removing it to see whether everything still compiles.
roystgnr
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This virtual keyword on this function was deprecated in 6fbd01f (2022), so it has been deprecated since the 1.8.x release series. The non-deprecated, non-virtual version of the function was made into a no-op. Therefore, there may be code which still calls this function, but it would just be doing nothing, so let's try removing it to see whether everything still compiles.