Skip to content

Fix ASR verify pass error while using Interactive #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ubaidsk merged 13 commits into from
Jun 8, 2024
Merged

Fix ASR verify pass error while using Interactive #2706

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f71b4a7
skipping function verification of Interactive ABI
Vipul-Cariappa May 16, 2024
36930eb
function verify checks for empty body
Vipul-Cariappa May 20, 2024
25e047e
intrinsic function's body & dependency left unchanged
Vipul-Cariappa May 22, 2024
7cda8e3
Fix ASR verify pass error while using Interactive
Vipul-Cariappa May 23, 2024
4a476b6
updated tests
Vipul-Cariappa May 28, 2024
5d1fe44
fix typos
Vipul-Cariappa May 28, 2024
5469ddf
update cmake to copy runtime python files to build dir
Vipul-Cariappa Jun 5, 2024
d899b15
fix test for the changes in main
Vipul-Cariappa Jun 5, 2024
2896a23
fix indentation for windows
Vipul-Cariappa Jun 5, 2024
ef4cf7c
fix for windows
Vipul-Cariappa Jun 6, 2024
06c7dd1
undo indentations
Vipul-Cariappa Jun 7, 2024
e65cfe1
indentation fix
Vipul-Cariappa Jun 7, 2024
b29338d
Merge branch 'main' into dev
Vipul-Cariappa Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
indentation fix
  • Loading branch information
@Vipul-Cariappa
Vipul-Cariappa committed Jun 7, 2024
commit e65cfe1206d640821bc6f2d492d2f03b416d865e
2 changes: 1 addition & 1 deletion src/libasr/string_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ std::string read_file(const std::string &filename)
std::vector<char> bytes(filesize);
ifs.read(&bytes[0], filesize);

return std::string(&bytes[0], filesize);
return replace(std::string(&bytes[0], filesize), "\r\n", "\n");
Copy link
Collaborator

@ubaidsk ubaidsk Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue that our tokenizer/parser should be updated/fixed to produce the same tokens/parse-tree on windows and unix.

}

std::string parent_path(const std::string &path) {
Expand Down