-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[12.x] Accept string bindings in give attribute #57747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 12.x
Are you sure you want to change the base?
Conversation
|
I've checked the failed check, but I don't understand why it fails. because the template is actually used as far as I can tell. |
Looks like a PHPStan bug 🤔 Have you tried swapping the order in the union? |
Yes, just now but with no success, sadly. |
|
Too bad |
|
I have no idea how to fix that error. 🙃 |
|
Changing the generic variant |
|
But that makes |
You're right, I've updated the PR accordingly |
I like to use a named binding from a container. This works properly, but PHPStan is complaining.
The property type of container make method accepts strings