[12.x] Standardize error handling patterns across components #57745
+263
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create HandlesExceptions trait for consistent error reporting - Add standardized exception context building - Implement consistent logging levels based on exception types - Update SyncQueue to use standardized error handling with job context - Update Database Connection to use standardized query exception reporting Key improvements: - Consistent exception reporting across all components - Rich context information for better debugging - Fallback mechanisms when exception handlers fail - Configurable logging levels per exception type - Better separation of concerns for error handling Benefits: - Improved debugging with consistent context - Better error tracking and monitoring - Reduced code duplication in error handling - More maintainable exception management - Enhanced observability across the framework All changes maintain backward compatibility while providing a foundation for consistent error handling patterns.
shaedrich
reviewed
Nov 11, 2025
| * | ||
| * @param \Throwable $exception | ||
| * @param mixed $default | ||
| * @param array $context |
Contributor
There was a problem hiding this comment.
Not sure if you want to narrow this down:
Suggested change
| * @param array $context | |
| * @param array<string, mixed> $context |
or perhaps, if you want it to be flat
Suggested change
| * @param array $context | |
| * @param array<string, scalar> $context |
Comment on lines
+154
to
+161
| $levelMap = [ | ||
| 'InvalidArgumentException' => 'warning', | ||
| 'LogicException' => 'error', | ||
| 'RuntimeException' => 'error', | ||
| 'BadMethodCallException' => 'error', | ||
| 'OutOfBoundsException' => 'warning', | ||
| 'UnexpectedValueException' => 'warning', | ||
| ]; |
Contributor
There was a problem hiding this comment.
Wouldn't $levelMap be a good candidate for a class property?
Comment on lines
+155
to
+160
| 'InvalidArgumentException' => 'warning', | ||
| 'LogicException' => 'error', | ||
| 'RuntimeException' => 'error', | ||
| 'BadMethodCallException' => 'error', | ||
| 'OutOfBoundsException' => 'warning', | ||
| 'UnexpectedValueException' => 'warning', |
Contributor
There was a problem hiding this comment.
Wouldn't it be state of the art to make the level an enum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces consistent error handling patterns across Laravel components through a new standardized trait and updates to key framework classes.
Changes Made
New Error Handling Foundation
Updated Components
Queue System (SyncQueue)
Database Layer (Connection)
Key Features
Consistent Error Reporting
Enhanced Debugging
Flexible Configuration
Robust Fallback Mechanisms
Benefits
Backward Compatibility
All changes are fully backward compatible:
Testing
This enhancement establishes a foundation for consistent error handling patterns throughout the Laravel framework while maintaining full backward compatibility.