Skip to content

kubelet: use wait.UntilWithContext for healthz server (structured logging) #135232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kubelet: use wait.UntilWithContext for healthz server (structured logging) #135232

wants to merge 1 commit into from

Conversation

@jsut21
Copy link

@jsut21 jsut21 commented Nov 8, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update cmd/kubelet/app/server.go to use the context-aware logging-friendly API wait.UntilWithContext for the healthz server loop instead of the non-contextual wait.Until. This aligns kubelet with the ongoing migration to contextual logging and removes a logcheck warning.

This is a minimal, targeted change; no behavior differences for the healthz endpoint are intended.

Which issue(s) this PR is related to:

Contributes to #126379

Special notes for your reviewer:

  • Single-file, small (size/S) change.
  • Verified locally with hack/verify-golang-lint.sh and make test WHAT=cmd/kubelet.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2025

Hi @jsut21. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2025
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Nov 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 8, 2025
@jsut21 jsut21 force-pushed the kubelet/healthz-untilwithcontext-126379 branch from 27357b0 to f9545b6 Compare November 8, 2025 07:18
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsut21
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsut21 jsut21 force-pushed the kubelet/healthz-untilwithcontext-126379 branch from f9545b6 to f157114 Compare November 8, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

No one assigned

Labels

area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Status: Triage
SIG Scheduling
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsut21 @k8s-ci-robot