-
Notifications
You must be signed in to change notification settings - Fork 41.7k
Add origins for the union validations errors #135229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/sig api-machinery |
|
/assign @thockin @aaron-prindle |
9eaeb6a to
fa9a6b8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lalitc375 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enhances the validation logic for union types in the Kubernetes API machinery. By adding
.WithOrigin("union")to the validation error returns, it provides more specific and actionable error messages. When a union validation fails (e.g., because multiple fields are set where only one is allowed), the error message will now clearly indicate that the "union" validation was the source of the failure. This makes it easier for developers to debug issues related to union type validation.The changes are applied consistently across various union validation scenarios, including discriminated and undiscriminated unions, as shown by the updates to the validation logic and the corresponding test files.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
The core of this change is the addition of
.WithOrigin("union")to the error construction inpkg/apis/resource/validation/validation.goandstaging/src/k8s.io/apimachinery/pkg/api/validate/union.go. The majority of the file changes are in the test files to update the expected error matchers to include this new origin.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: