Skip to content

Conversation

@lalitc375
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enhances the validation logic for union types in the Kubernetes API machinery. By adding .WithOrigin("union") to the validation error returns, it provides more specific and actionable error messages. When a union validation fails (e.g., because multiple fields are set where only one is allowed), the error message will now clearly indicate that the "union" validation was the source of the failure. This makes it easier for developers to debug issues related to union type validation.

The changes are applied consistently across various union validation scenarios, including discriminated and undiscriminated unions, as shown by the updates to the validation logic and the corresponding test files.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

The core of this change is the addition of .WithOrigin("union") to the error construction in pkg/apis/resource/validation/validation.go and staging/src/k8s.io/apimachinery/pkg/api/validate/union.go. The majority of the file changes are in the test files to update the expected error matchers to include this new origin.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and pohly November 7, 2025 22:47
@lalitc375
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Nov 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 7, 2025
@lalitc375
Copy link
Contributor Author

/assign @thockin @aaron-prindle

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lalitc375
Once this PR has been reviewed and has the lgtm label, please ask for approval from thockin. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

4 participants