fix: disable ssl #87
Merged
fix: disable ssl #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR disables SSL connections for MySQL database connections by adding SSL configuration to the database connection setup.
- Adds SSL disabled configuration to MySQL connector
- Updates database connection function to use the new SSL settings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| database=os.getenv("DB_NAME", "demo"), | ||
| ) | ||
|
|
||
| _EXTRA = {"ssl_disabled": True} |
There was a problem hiding this comment.
Disabling SSL for database connections removes encryption between the application and database, potentially exposing sensitive data in transit. Consider using proper SSL certificates or restricting this to development environments only.
Suggested change
| _EXTRA = {"ssl_disabled": True} | |
| # Only disable SSL if DB_SSL_DISABLED is set to "true" (case-insensitive) | |
| _EXTRA = {} | |
| if os.getenv("DB_SSL_DISABLED", "false").lower() == "true": | |
| _EXTRA["ssl_disabled"] = True |
AkashKumar7902
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.