feat: fastapi + redis sample app #24
Conversation
|
Hi @Sonichigo @Swpn0neel can you please review it? |
Signed-off-by: Samyabrata Maji <samyabratamaji334@gmail.com>
Hey, @sammaji can add a readme file with instructions and curl commands.! |
|
@Sonichigo there is a readme file with instructions and some curl commands for interacting with the api. |
Swpn0neel
left a comment
There was a problem hiding this comment.
LGTM! But for further improvement you can add more curl commands to cover all of your operations, and also you can generate the test coverage report using Keploy!
| }' | ||
| ``` | ||
| ```bash | ||
| curl --location 'http://127.0.0.1:8000/todos/' |
There was a problem hiding this comment.
this curl command isn't working
| Let's make some sample API requests. | ||
|
|
||
| ```bash | ||
| curl --location 'http://127.0.0.1:3000/todos/' \ |
There was a problem hiding this comment.
this one throws 400 bad request
|
|
||
| This will start your server at `https://localhost:3000`. | ||
|
|
||
| ## Setup With Docker |
There was a problem hiding this comment.
this paragraph isn't required
|
|
||
| If you docker installed, simply run `docker compose up` and it will start your server. | ||
|
|
||
| Make sure you have provided all the environment variables in `.env` file. |
There was a problem hiding this comment.
please add .env.sample on what things to add in the file.
|
|
||
| Keploy can be installed on Linux directly. If you're on windows, you would need Windows Subsystem For Linux (WSL). Based on your system architecture, install the keploy latest binary release. Read more about it [here](https://keploy.io/docs/server/installation/). | ||
|
|
||
| ### For Linux, MacOS and WSL |
There was a problem hiding this comment.
You can add one-click installation url and remove line from 49, to 58.
|
Stale PR. Closing the pr since now it has conflicts as well |
No description provided.