Skip to content

Conversation

@shiavm006
Copy link

@shiavm006 shiavm006 commented Jan 5, 2026

Describe the changes that are made

  • Add golangci-lint hook to .pre-commit-config.yaml
  • Add pre-commit setup documentation to CONTRIBUTING.md
  • Hook uses existing .golangci.yml configuration
  • Helps catch linting issues before commit

Links & References

Closes: #2690

🔗 Related PRs

  • NA

🐞 Related Issues

📄 Related Documents

  • NA

What type of PR is this? (check all applicable)

  • 📦 Chore
  • 🍕 Feature
  • 🐞 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🔁 CI
  • ⏩ Revert

Added e2e test pipeline?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added comments for hard-to-understand areas?

  • 🙅 no, because the code is self-explanatory

Added to documentation?

  • ✅ CONTRIBUTING.md

Are there any sample code or steps to test the changes?

  • 🙅 no, because it is not needed

Self Review done?

  • ✅ yes

- Add golangci-lint hook to .pre-commit-config.yaml
- Add pre-commit setup documentation to CONTRIBUTING.md
- Hook uses existing .golangci.yml configuration
- Helps catch linting issues before commit

Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

The CLA check failed. Please ensure you have:

  • Signed the CLA by commenting 'I have read the CLA Document and I hereby sign the CLA.'
  • Used the correct email address in your commits (matches the one you used to sign the CLA).

After fixing these issues, comment 'recheck' to trigger the workflow again.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@shiavm006
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@shiavm006
Copy link
Author

cc @Sarthak160 @gouravkrosx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant