Additional: Replace deprecated substr() with slice() and charAt() in cifES.js #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Depreciated String
Additional: Replace deprecated substr() with slice() and charAt() in cifES.js
Oct 3, 2025
Copilot finished work on behalf of
bytestream
October 3, 2025 10:57
Member
|
@copilot revert the changes to |
Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com>
Contributor
Author
Member
|
@copilot do not modify |
Copilot finished work on behalf of
bytestream
October 3, 2025 11:01
Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com>
Contributor
Author
Copilot finished work on behalf of
bytestream
October 3, 2025 11:05
Member
|
@copilot is there ever a case where |
Contributor
Author
No, Line 98 calculates:
Line 99 handles the edge case:
Final range: |
Copilot finished work on behalf of
bytestream
October 3, 2025 11:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecated substr() usage in cifES.js
Issue: The
String.prototype.substr()method is deprecated in JavaScript.Changes Made:
( all_sum ).toString().substr( -1 )with( all_sum ).toString().slice( -1 )"JABCDEFGHI".substr( control_digit, 1 )with"JABCDEFGHI".charAt( control_digit )Technical Details:
slice(-1)extracts the last character, equivalent tosubstr(-1)charAt(index)extracts a single character at the specified index, equivalent tosubstr(index, 1)slice()andcharAt()are standard, non-deprecated methodsTesting:
The changes are minimal and surgical - only 2 lines modified in
src/additional/cifES.jsto replace the deprecated method with modern alternatives.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.