Skip to content

Fix: focus event fires on disabled inputs #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Fix: focus event fires on disabled inputs #5623

wants to merge 23 commits into from

Conversation

@ac-mmi
Copy link
Contributor

@ac-mmi ac-mmi commented Feb 7, 2025

This PR addresses the issue where calling .focus() on a disabled input still triggers a focus event in jQuery 3.7+, which is inconsistent with native behavior.

Changes Made:

  1. Added a flag in trigger.js to prevent focus events from firing on disabled inputs.
  2. Ensures .focus() on a disabled element does nothing, matching native JavaScript behavior.

Impact:

  1. Fixes an inconsistency without affecting other focusable elements.
  2. No breaking changes.

Fixes #5620

ac-mmi and others added 23 commits July 21, 2024 17:51
@mgol mgol closed this Feb 11, 2025
@mgol mgol mentioned this pull request Feb 11, 2025
Closed
@mgol
Copy link
Member

mgol commented Feb 11, 2025

I’m sorry, I mixed up PRs, let me reopen this one.

I don’t think the changes will be that small, though; we also need to handle at least blur, get new tests added and clearly state which cases we want to support and which we give up on for now - e.g., there are many quirks with focus & click propagation in elements inside disabled fieldsets.

@mgol mgol reopened this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

focus event fires on disabled inputs

2 participants

@ac-mmi @mgol