Skip to content

fix: bigint cause error #15702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpojer merged 1 commit into from
Jul 3, 2025
Merged

fix: bigint cause error #15702

cpojer merged 1 commit into from
Jul 3, 2025

Conversation

@BondarenkoAlex
Copy link
Contributor

@BondarenkoAlex BondarenkoAlex commented Jun 25, 2025

Closes #15698

@netlify
Copy link

netlify bot commented Jun 25, 2025 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ee959cb
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/68669d6e054f0600083bd588
😎 Deploy Preview https://deploy-preview-15702--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@BondarenkoAlex BondarenkoAlex force-pushed the to-throw-bigint branch 2 times, most recently from f05ba60 to 661b7dd Compare June 25, 2025 14:03
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 25, 2025 •
edited
Loading

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15702

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15702

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15702

create-jest

npm i https://pkg.pr.new/create-jest@15702

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15702

expect

npm i https://pkg.pr.new/expect@15702

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15702

jest

npm i https://pkg.pr.new/jest@15702

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15702

jest-circus

npm i https://pkg.pr.new/jest-circus@15702

jest-cli

npm i https://pkg.pr.new/jest-cli@15702

jest-config

npm i https://pkg.pr.new/jest-config@15702

@jest/console

npm i https://pkg.pr.new/@jest/console@15702

@jest/core

npm i https://pkg.pr.new/@jest/core@15702

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15702

jest-diff

npm i https://pkg.pr.new/jest-diff@15702

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15702

jest-each

npm i https://pkg.pr.new/jest-each@15702

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15702

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15702

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15702

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15702

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15702

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15702

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15702

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15702

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15702

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15702

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15702

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15702

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15702

jest-mock

npm i https://pkg.pr.new/jest-mock@15702

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15702

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15702

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15702

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15702

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15702

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15702

jest-runner

npm i https://pkg.pr.new/jest-runner@15702

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15702

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15702

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15702

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15702

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15702

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15702

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15702

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15702

@jest/types

npm i https://pkg.pr.new/@jest/types@15702

jest-util

npm i https://pkg.pr.new/jest-util@15702

jest-validate

npm i https://pkg.pr.new/jest-validate@15702

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15702

jest-worker

npm i https://pkg.pr.new/jest-worker@15702

pretty-format

npm i https://pkg.pr.new/pretty-format@15702

commit: ee959cb

@cpojer
Copy link
Member

cpojer commented Jun 27, 2025

When you cast a bigint to a Number, you lose precision. Wouldn't it be better to cast it to a String?

@BondarenkoAlex
Copy link
Contributor Author

BondarenkoAlex commented Jun 27, 2025

When you cast a bigint to a Number, you lose precision. Wouldn't it be better to cast it to a String?

Yes. I thought about it. Maybe it will be better.
I will rewrite it to a string.

@cpojer
Copy link
Member

cpojer commented Jul 2, 2025

@BondarenkoAlex are you still working on this?

@BondarenkoAlex
Copy link
Contributor Author

BondarenkoAlex commented Jul 2, 2025

Yes, I am working on this

@BondarenkoAlex
Copy link
Contributor Author

BondarenkoAlex commented Jul 3, 2025

For example
https://codepen.io/BondarenkoAlex/pen/pvJXNqN?editors=0012

@BondarenkoAlex BondarenkoAlex marked this pull request as ready for review July 3, 2025 21:08
@cpojer cpojer merged commit a3d1e2e into jestjs:main Jul 3, 2025
76 checks passed
@github-actions
Copy link

github-actions bot commented Aug 3, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cpojer cpojer cpojer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: toThrow does not work with Error causes involving bigints

2 participants

@BondarenkoAlex @cpojer