Skip to content

chore: lint usage of Arrays #14804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 7 commits into from
Dec 29, 2023
Merged

chore: lint usage of Arrays #14804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
86ba6f0
chore: lint usage of Arrays
SimenB Dec 29, 2023
a7ff579
Merge branch 'main' into lint-array-usage
SimenB Dec 29, 2023
3e465a3
fix test
SimenB Dec 29, 2023
8fc5a1a
bang
SimenB Dec 29, 2023
a492844
more bang
SimenB Dec 29, 2023
e117610
moooooar
SimenB Dec 29, 2023
5c6d058
type array
SimenB Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bang
  • Loading branch information
@SimenB
SimenB committed Dec 29, 2023
commit 8fc5a1a2836802f9e1ee99310200094a5f2cae58
2 changes: 1 addition & 1 deletion packages/jest-reporters/src/GitHubActionsReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export default class GitHubActionsReporter extends BaseReporter {
): ResultTreeNode {
const node: ResultTreeNode = {
children: [],
name: ancestors.at(-1),
name: ancestors.at(-1)!,
passed: true,
};
const branches: Array<Array<string>> = [];
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-snapshot/src/dedentLines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const dedentMarkup = (input: Array<string>, output: Array<string>): boolean => {
return false; // because text has more than one adjacent line
}

const indentationLengthOfTag = stack.at(-1);
const indentationLengthOfTag = stack.at(-1)!;
output.push(line.slice(indentationLengthOfTag + 2));
isText = true;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-snapshot/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function stripAddedIndentation(inlineSnapshot: string) {
return inlineSnapshot;
}

if (lines[0].trim() !== '' || lines.at(-1).trim() !== '') {
if (lines[0].trim() !== '' || lines.at(-1)!.trim() !== '') {
// If not blank first and last lines, abort.
return inlineSnapshot;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-snapshot/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ export const processPrettierAst = (
return;
}

const parent = ancestors.at(-1).node;
const parent = ancestors.at(-1)!.node;
const startColumn =
isAwaitExpression(parent) && parent.loc
? parent.loc.start.column
Expand Down