Fix jest.mock in jest.mock

jestjs · SimenB · Aug 30, 2022 · Aug 28, 2022 · Aug 28, 2022 · Aug 28, 2022
commit b80915c0df0133faaa0a07bbc05c95e38c4c741b
diff --git a/packages/babel-plugin-jest-hoist/src/__tests__/__snapshots__/hoistPlugin.test.ts.snap b/packages/babel-plugin-jest-hoist/src/__tests__/__snapshots__/hoistPlugin.test.ts.snap
@@ -38,6 +38,56 @@ function _getJestObj() {
 }
 
 
+`;
+
+exports[`babel-plugin-jest-hoist global jest.mock within jest: global jest.mock within jest 1`] = `
+
+jest.mock('some-module', () => {
+  jest.mock('some-module');
+});
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+_getJestObj().mock('some-module', () => {
+  _getJestObj().mock('some-module');
+});
+
+function _getJestObj() {
+  const {jest} = require('@jest/globals');
+
+  _getJestObj = () => jest;
+
+  return jest;
+}
+
+
+`;
+
+exports[`babel-plugin-jest-hoist imported jest.mock within jest: imported jest.mock within jest 1`] = `
+
+import {jest} from '@jest/globals';
+
+jest.mock('some-module', () => {
+  jest.mock('some-module');
+});
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+_getJestObj().mock('some-module', () => {
+  _getJestObj().mock('some-module');
+});
+
+function _getJestObj() {
+  const {jest} = require('@jest/globals');
+
+  _getJestObj = () => jest;
+
+  return jest;
+}
+
+import {jest} from '@jest/globals';
+
+
 `;
 
 exports[`babel-plugin-jest-hoist required \`jest\` within \`jest\`: required \`jest\` within \`jest\` 1`] = `

diff --git a/packages/babel-plugin-jest-hoist/src/__tests__/hoistPlugin.test.ts b/packages/babel-plugin-jest-hoist/src/__tests__/hoistPlugin.test.ts
@@ -90,7 +90,7 @@ pluginTester({
       formatResult,
       snapshot: true,
     },
-    'imported jest within jest': {
+    'imported jest.mock within jest': {
       code: formatResult(`
         import {jest} from '@jest/globals';
 
@@ -101,6 +101,15 @@ pluginTester({
       formatResult,
       snapshot: true,
     },
+    'global jest.mock within jest': {
+      code: formatResult(`
+        jest.mock('some-module', () => {
+          jest.mock('some-module');
+        });
+      `),
+      formatResult,
+      snapshot: true,
+    },
   },
   /* eslint-enable */
 });
diff --git a/packages/babel-plugin-jest-hoist/src/index.ts b/packages/babel-plugin-jest-hoist/src/index.ts
@@ -161,6 +161,19 @@ FUNCTIONS.mock = args => {
               hoistedVariables.add(node);
               isAllowedIdentifier = true;
             }
+          } else if (binding?.path.isImportSpecifier()) {
+            const importDecl = binding.path
+              .parentPath as NodePath<ImportDeclaration>;
+            const imported = binding.path.node.imported;
+            if (
+              importDecl.node.source.value === JEST_GLOBALS_MODULE_NAME &&
+              (isIdentifier(imported) ? imported.name : imported.value) ===
+                JEST_GLOBALS_MODULE_JEST_EXPORT_NAME
+            ) {
+              isAllowedIdentifier = true;
+              // Imports are already hoisted, so we don't need to add it
+              // to hoistedVariables.
+            }
           }
         }