-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix widget view persistence. #7680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Checked out the branch and it does fix the issue. |
|
@jdfreder thanks for the fix, @SylvainCorlay thanks for the report and confirmation of the fix. @jdfreder is this something that can be reasonably tested? |
|
|
|
@minrk it's ugly, but the last commit adds a test. |
|
It wasn't possible to test the return value of |
|
In general, now that you are using the local storage for the widgets, Phantomjs' local storage should probably be cleared before running any test suite. |
|
for what it's worth, @jdfreder's analysis and fix of the problem seems appropriate to me. |
|
Yeah, 👍 on this. |
|
@minrk yeah, the |
|
Makes sense, you just said it was ugly, and I thought there might be a way for it to be less so. Thanks! |
Corrects a variable's scope.
closes #7679
@SylvainCorlay