Remove the popup widget #7341
Merged
Remove the popup widget #7341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I need to run through the example notebooks before this gets merged. |
Contributor
Author
|
I updated the relevant example notebooks. |
Member
|
Seems good to me... |
Member
|
+1 |
Contributor
|
Why did you remove this? |
|
@jdfreder , I was planning on using the popup widget with a default state of being cemented in the page. What is the right way to give this functionality given this removal? Just trying not to require code changes when the next version of IPython is released. Should this be handled outside of the widgets framework? I.e., some extra custom JS? |
Member
|
Reasoning behind moving this: #7281 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for the popup widget.
closes #7281
closes #7299
closes #7348
Pinging @jasongrout who I know is using this. I didn't remove any of the functionality required to implement and maintain it independent of IPython.