Add removeprefix and removesuffix to pystring#30
Merged
grdanny merged 2 commits intoimageworks:masterfrom Jul 23, 2023
Merged
Conversation
Add removeprefix and removesuffix to pystring. Python 3.9 added removeprefix and removesuffix methods to Pythons string class. Add them to pystring to match the interfaces.
Collaborator
|
Hello There, Thanks for the pull request, this is a good suggestion! Feel free to let me know if you have any questions. Thanks again! |
Contributor
Author
|
I have signed the CLA and sent it to iamgeworks office in Culver City, I hope it has arrived. |
Member
|
@niclasr I'm not sure anybody has ever sent a CLA to us in the post before, and I'm also not sure who's going to receive it after 2 years of everybody working from home. Please just email an image of the signature page to opensource@imageworks.com |
Contributor
Author
|
Ok I will do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add removeprefix and removesuffix to pystring.
Python 3.9 added removeprefix and removesuffix
methods to Pythons string class. Add them to
pystring to match the interfaces.