Add support for plugin UI i18n #2598
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
There currently is no support for internationalization of plugin UIs, short of using a custom user interface. This feels like killing a fly using a cannon.
💡 Proposed solution
Use the package.json spec
directoriesobject to provide a path to internationalizedconfig.schema,jsonfiles.Refer to Support i18n in plugin UI for details.
⚙️ Release Notes
Add support for
config.schema,jsoni18n files.➕ Additional Information
In `src/modules/plugins/plugins.service.ts:954
the default could be changed from
ento the browser language. I wasn't sure how to retrieve that value.