Skip to content

latest <- beta-1.9.0 #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 11, 2025
Merged

latest <- beta-1.9.0 #3782

merged 6 commits into from
Feb 11, 2025

Conversation

@donavanbecker
Copy link
Contributor

@donavanbecker donavanbecker commented Feb 10, 2025 •
edited
Loading

v1.9.0 (2025-02-11)

Changed

Homebridge Dependencies

  • hap-nodejs @ v0.12.3

justjam2013 and others added 5 commits January 18, 2025 15:02
@justjam2013
Added method updateDisplayName() (#3764)
ab58890 
* Added method updateDisplayName()

* Sync _associatedHAPAccessory.displayName and displayName at serialization
@justjam2013
Fixed method handleUpdatePlatformAccessories() (#3765)
b0ec950 
* Fixed method handleUpdatePlatformAccessories()

* Fixed filter matching condition and removed lint annotation
@donavanbecker
update dependencies
1ba55b5
@Vvorcun @donavanbecker
Make it possible to set Characteristic.SerialNumber via config.json (#…
b156845 
…3761)
@bwp91
fix: check for valid array in handleUpdatePlatformAccessories
13da19f
@donavanbecker donavanbecker marked this pull request as draft February 10, 2025 12:45
@coveralls
Copy link

coveralls commented Feb 10, 2025

Pull Request Test Coverage Report for Build 13241162043

Details

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 28.369%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bridgeService.ts 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
src/plugin.ts 1 6.54%
Totals Coverage Status
Change from base Build 11524566418: 0.2%
Covered Lines: 431
Relevant Lines: 1376
💛 - Coveralls

@bwp91 @donavanbecker
minor dependency updates (#3781)
86e84e0 
- Added method updateDisplayName() (#3764) (@justjam2013)
- Fixed method handleUpdatePlatformAccessories() (#3765) (@justjam2013)
- Make it possible to set Characteristic.SerialNumber via config.json (#3761) (@Vvorcun)
- minor dependency updates
- fix: check for valid array in `handleUpdatePlatformAccessories`
- minor dependency updates

- `hap-nodejs` @ `v0.12.3`
@donavanbecker donavanbecker marked this pull request as ready for review February 11, 2025 05:48
@donavanbecker donavanbecker enabled auto-merge (squash) February 11, 2025 05:48
@bwp91 bwp91 disabled auto-merge February 11, 2025 07:50
@bwp91 bwp91 enabled auto-merge (rebase) February 11, 2025 07:51
@bwp91 bwp91 merged commit 8a71b77 into latest Feb 11, 2025
18 checks passed
@bwp91 bwp91 deleted the beta-1.9.0 branch February 11, 2025 07:53
omarmohsen111
omarmohsen111 reviewed May 8, 2025
View reviewed changes
Copy link

@omarmohsen111 omarmohsen111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwp91 bwp91 bwp91 approved these changes

@NorthernMan54 NorthernMan54 Awaiting requested review from NorthernMan54

+1 more reviewer

@omarmohsen111 omarmohsen111 omarmohsen111 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

latest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@donavanbecker @coveralls @bwp91 @omarmohsen111 @justjam2013 @Vvorcun