Set min sdk to 23 (drop support for Android 5 and 5.1) #5800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This PR should also require a docs update. We mention the minimum on the get started page but a few features were android 6 only like the DND sensor |
jpelgrom
reviewed
Sep 16, 2025
Member
jpelgrom
left a comment
There was a problem hiding this comment.
This simplifies or removes a surprising amount of checks!
app/src/main/kotlin/io/homeassistant/companion/android/HomeAssistantApplication.kt
Outdated
Show resolved
Hide resolved
…istantApplication.kt Co-authored-by: Joris Pelgröm <jpelgrom@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR set the min sdk to 23, since some of the dependencies we are using like firebase or even androidx dropped the support for 21 and 22.
This PR cleanup the codebase from all the unneeded checks.
Checklist
Link to pull request in documentation repositories
User Documentation: home-assistant/companion.home-assistant#1235
Any other notes
Closes #5582