Skip to content

Conversation

@soubiliz
Copy link

@soubiliz soubiliz commented Sep 7, 2025

see samsung references :

Summary

Add keyguard widget category to all widget, doing so allow homeassistant widgets to be listed in cover screen option on z flip line of products (I own a broken z flip 5 and z flip 7)

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

Screenshot_20250907_073901_One UI Cover Home
Screenshot_20250907_073619_One UI Cover Home
Screenshot_20250907_073507_One UI Cover Home
https://github.com/user-attachments/assets/c2c574a7-68fd-42ed-b1c2-b51cb482009d

Link to pull request in documentation repositories

User Documentation: home-assistant/companion.home-assistant#

Developer Documentation: home-assistant/developers.home-assistant#

Any other notes

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @soubiliz

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft September 7, 2025 05:45
@home-assistant
Copy link

home-assistant bot commented Sep 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@soubiliz soubiliz marked this pull request as ready for review September 7, 2025 05:46
@soubiliz soubiliz marked this pull request as draft September 7, 2025 05:56
@soubiliz
Copy link
Author

soubiliz commented Sep 7, 2025

I'm pretty new to android development I don't know why the cell width isn't taken in consideration, on newer version of the flex window you can have multiple widget on the same screen.
here all widget are stuck on 4x4

@soubiliz
Copy link
Author

soubiliz commented Sep 7, 2025

Samsung seams to not use at all the target cell and want a fixed size for widgets, I'm not sure if there is a way to detect that you are on the cover screen and use onUpdate to have a fixed size only there

@soubiliz soubiliz changed the title Make app windget available to Samsung Z Flip flex window Make app widget available to Samsung Z Flip flex window Sep 7, 2025
@jpelgrom
Copy link
Member

Samsung seams to not use at all the target cell and want a fixed size for widgets, I'm not sure if there is a way to detect that you are on the cover screen and use onUpdate to have a fixed size only there

After looking at Samsung's documentation you linked: maybe it is because the Samsung-specific metadata XML is missing, have you tried adding that? (Looks like one XML could be used for all widgets as it has just one property.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants