feat: prioritize exact and smaller matches in completion #14700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to get some eyeballs and hopefully some feedback on these changes. As #14566 rightfully points out, it's unintuitive that exact matches are shown last after all the partial matches.
I just did the most straightforward thing, which is to check if the pattern exactly matches the text, and give that a higher priority sort over anything else. It also seems natural to me to display smaller matches first, but I don't think this is that important.
Closes #14566
Note: I wanted to add tests for this but AFAICT there are no tests currently which exercise the sorting of completion items. I was going to add my own, but since the
Completionstruct takes anEditor, and I couldn't find any tests which actually initialized a wholeEditorinstance, I wasn't sure if this was the right approach.