Skip to content

Wire httpx transport in gql-cli #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

Wire httpx transport in gql-cli #513

merged 1 commit into from
Dec 11, 2024

Conversation

@mss
Copy link
Contributor

@mss mss commented Dec 11, 2024 •
edited
Loading

I thought that I had some problem with the aiohttp backend and tried to use httpx instead just to discover that it wasn't available.

My problem was somewhere else but this change makes the httpx backend available for the gql-cli command.

@codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57ef910) to head (0be45b7).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         3102      3127   +25     
=========================================
+ Hits          3102      3127   +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mss
Copy link
Contributor Author

mss commented Dec 11, 2024

Ok, now I know why that other line was formatted so weirdly, to make flake8 happy. I will revert that line.

@mss mss force-pushed the feature/gql-cli-with-httpx branch from 963e0c2 to 06e8de0 Compare December 11, 2024 12:29
@mss mss force-pushed the feature/gql-cli-with-httpx branch from 06e8de0 to 0be45b7 Compare December 11, 2024 12:37
@mss
Copy link
Contributor Author

mss commented Dec 11, 2024

I also added a test so codecov is hopefully happy again.

leszekhanusz
leszekhanusz approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@leszekhanusz leszekhanusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leszekhanusz leszekhanusz merged commit b7c5865 into graphql-python:master Dec 11, 2024
15 checks passed
@mss mss deleted the feature/gql-cli-with-httpx branch December 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leszekhanusz leszekhanusz leszekhanusz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mss @leszekhanusz