Skip to content

Conversation

@zhekazuev
Copy link
Contributor

@zhekazuev zhekazuev commented Jan 19, 2024

@github-actions github-actions bot added the semver:minor Backwards-compatible change label Jan 19, 2024
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 19, 2024
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 19, 2024
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 19, 2024
@coveralls
Copy link

coveralls commented Jan 19, 2024

Coverage Status

coverage: 77.835%. remained the same
when pulling 97d56c7 on zhekazuev:feature/add-db-instance-access-field
into 8587253 on gophercloud:master.

@zhekazuev
Copy link
Contributor Author

@EmilienM Hi,

What better to use for Access field, a pointer(*AccessOpts) or a value(AccessOpts)?
Commit with changes: 0b8b1e1

From the risks and style side.
I prefer to not use pointers where possible, to avoid null pointer issues, but maybe for current scenario there is no option with a value.

@zhekazuev zhekazuev changed the title [wip][db/v1/instances] add access field [wip][db/v1/instances][trove][database] add access field Jan 20, 2024
@zhekazuev zhekazuev changed the title [wip][db/v1/instances][trove][database] add access field [wip][db/v1/instances] add access field - trove database Jan 20, 2024
@zhekazuev zhekazuev changed the title [wip][db/v1/instances] add access field - trove database [wip][db/v1/instances] add access field - trove database dbaas Jan 20, 2024
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:minor Backwards-compatible change labels Jan 22, 2024
@zhekazuev zhekazuev marked this pull request as ready for review January 22, 2024 12:58
@zhekazuev zhekazuev changed the title [wip][db/v1/instances] add access field - trove database dbaas [db/v1/instances] add access field - trove database dbaas Jan 22, 2024
@zhekazuev
Copy link
Contributor Author

@EmilienM Hi,

What better to use for Access field, a pointer(*AccessOpts) or a value(AccessOpts)? Commit with changes: 0b8b1e1

From the risks and style side. I prefer to not use pointers where possible, to avoid null pointer issues, but maybe for current scenario there is no option with a value.

@EmilienM Hi,

Could you review these changes?

I just added new field - Access. Without methods specific for that field, e.g.:

  • UpdateInstanceAccessbility - update access options like here.

And decided to use the value for Access struct instead of pointers as described below.
If it is important to use pointers, I can restore the changes to the pointer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[db/v1/instances] missed access field - trove database dbaas

2 participants