Add support for baremetal v1 volume connectors and targets #2436
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
|
@haoziwu could you please write a PR message like it's documented and also include acceptance tests, so your code will be exercised in our CI: Thanks a lot for your contribution and let us know if you need help/support |
@EmilienM hi, i write acceptance test codes and test them in my real openstack environment, all acceptance test case and unit test case which i newly add pass, but in this PR submit environment, it always can not pass， i really do not know what to do next. |
@EmilienM here is the openstack baremetal volume api reference, https://docs.openstack.org/api-ref/baremetal/?expanded=create-volume-target-detail,show-volume-target-details-detail |
…ophercloud/gophercloud#2436 , and put them in the same directory with this baremetal-operator
The baremetal ussuri and train jobs are broken due to virtualbmc's removal of python 3.6 support. I have submitted patches to ironic to fix the devstack installation but these patches have stalled. See #2439 for details. |
|
I wanted to re-run the tests but I think this needs a rebase. Please rebase and let's see how tests work now. |
|
@EmilienM hello, i make a new branch for your test: https://github.com/haoziwu/gophercloud/tree/bmvolume-test |
Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
be8bef4 to
e0718d8
Compare
|
Failed to assess the semver bump. See logs for details. |
There is no interfaces in baremetal v1 for volume connectors and targets, while volume connectors and targets setting is necessary when baremetal is boot from remote volume, so we should add some volume client api in baremetal v1 directory.
In the process of adding these apis, in unit test i find when i use ExtractInto function in results.go to json.unmarshal pagination.LinkedPageBase.PageResult body to some structure, it will throw exception like "json: cannot unmarshal string into Go value of type map[string]interface {}" , when i change codes of ExtractInto in results.go, the exception will disappear.