Add Support for User Domain Name/ID/Default Domain #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users should be able to use OS_USER_DOMAIN_NAME, OS_USER_DOMAIN_ID or OS_DEFAULT_DOMAIN to specify the DOMAIN of user. Fixes: gophercloud#2418
mandre
reviewed
Jun 27, 2022
| if username != "" && domainID == "" && domainName == "" { | ||
| return nilOptions, gophercloud.ErrMissingAnyoneOfEnvironmentVariables{ | ||
| EnvironmentVariables: []string{"OS_DOMAIN_ID", "OS_DOMAIN_NAME"}, | ||
| if userDomainID == "" && userDomainName == "" && defaultDomain == "" { |
Contributor
There was a problem hiding this comment.
This doesn't look right. The new code only runs when using application credentials with missing OS_APPLICATION_CREDENTIAL_ID, which may not be what we want.
As far as I understand from https://docs.openstack.org/python-openstackclient/latest/cli/authentication.html#authenticating-using-identity-server-api-v3, the logic should be outside of the appcreds conditional branch, but I'm clearly not an expert on keystone authentication so I could very well be totally wrong 😄
Would love to have more eyes on this patch.
Contributor
|
My understanding is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users should be able to use OS_USER_DOMAIN_NAME, OS_USER_DOMAIN_ID or
OS_DEFAULT_DOMAIN to specify the DOMAIN of user.
Fixes: #2418
Reference:
https://docs.openstack.org/python-openstackclient/latest/cli/authentication.html#authenticating-using-identity-server-api-v3