This repository was archived by the owner on Apr 1, 2026. It is now read-only.
test: stop checking text generation contents#935
Merged
Conversation
shobsi
reviewed
Aug 28, 2024
| assert df.shape == (3, 3) | ||
| assert "ml_generate_text_llm_result" in df.columns | ||
| series = df["ml_generate_text_llm_result"] | ||
| assert all(series.str.len() > 20) |
Contributor
There was a problem hiding this comment.
Is this precisely the part which was failing due to instability?
Contributor
Author
There was a problem hiding this comment.
It is the flakiness of the .predict. In fact this time it isn't instability but a quota issue. b/362768658.
It is not the issue of create model.
shobsi
approved these changes
Aug 28, 2024
arwas11
pushed a commit
that referenced
this pull request
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change, the .predict check shouldn't be flaky. While still keeping the "retry" label since:
I'll keep an eye on the tests. Eventually we should remove the "retry" labels, at least for GA models.