Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

docs: add an example notebook about line graphs#197

Merged
gcf-merge-on-green[bot] merged 10 commits intomainfrom
b299356569-covid-notebook
Nov 15, 2023
Merged

docs: add an example notebook about line graphs#197
gcf-merge-on-green[bot] merged 10 commits intomainfrom
b299356569-covid-notebook

Conversation

@milkshakeiii
Copy link
Copy Markdown
Contributor

@milkshakeiii milkshakeiii commented Nov 11, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@milkshakeiii milkshakeiii requested review from a team and GarrettWu November 11, 2023 22:22
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 11, 2023
GarrettWu
GarrettWu reviewed Nov 13, 2023
View reviewed changes
Comment thread notebooks/visualization/bq_dataframes_covid_line_graphs.ipynb Outdated
Comment thread notebooks/visualization/bq_dataframes_covid_line_graphs.ipynb
GarrettWu
GarrettWu reviewed Nov 13, 2023
View reviewed changes
Comment thread notebooks/visualization/bq_dataframes_covid_line_graphs.ipynb Outdated
ashleyxuu
ashleyxuu reviewed Nov 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GarrettWu Since @milkshakeiii is on leave now, how about we check in the notebook, and edit it afterwards?

@milkshakeiii
Copy link
Copy Markdown
Contributor Author

milkshakeiii commented Nov 14, 2023

@GarrettWu Since @milkshakeiii is on leave now, how about we check in the notebook, and edit it afterwards?

It's okay, this is my last PR, I can respond to a few comments ! Thanks!

@milkshakeiii milkshakeiii reopened this Nov 14, 2023
@milkshakeiii milkshakeiii added the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit f957b27 into main Nov 15, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the b299356569-covid-notebook branch November 15, 2023 02:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2023
@release-please release-please bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milkshakeiii @GarrettWu @ashleyxuu