This repository was archived by the owner on Apr 1, 2026. It is now read-only.
docs: add snippets for Matrix Factorization tutorials#1630
Merged
Conversation
…-bigquery-dataframes into b338873783-mf-snippets
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
Contributor
|
Snippet bot failure looks like a real one:
Edit: I created a suggested commit that I think should fix that. |
tswast
reviewed
May 7, 2025
tswast
reviewed
May 7, 2025
tswast
reviewed
May 7, 2025
tswast
reviewed
May 7, 2025
Comment on lines
+127
to
+131
| # Load movies | ||
| movies = bpd.read_gbq("bqml_tutorial.movies") | ||
|
|
||
| # Merge the movies df with the previously created predicted df | ||
| merged_df = bpd.merge(predicted, movies, left_on="item_id", right_on="movie_id") |
Contributor
There was a problem hiding this comment.
predicted here is only a subset. The SQL shows creating a table of all the predictions.
CREATE OR REPLACE TABLE `bqml_tutorial.recommend`
AS
SELECT
*
FROM
ML.RECOMMEND(MODEL `bqml_tutorial.mf_explicit`);
Did we implement a way for predict() to work without any inputs like in the SQL?
Suggested change
| # Load movies | |
| movies = bpd.read_gbq("bqml_tutorial.movies") | |
| # Merge the movies df with the previously created predicted df | |
| merged_df = bpd.merge(predicted, movies, left_on="item_id", right_on="movie_id") | |
| predicted = model.predict() | |
| # Load movies | |
| movies = bpd.read_gbq("bqml_tutorial.movies") | |
| # Merge the movies df with the previously created predicted df | |
| merged_df = bpd.merge(predicted, movies, left_on="item_id", right_on="movie_id") |
Contributor
Author
There was a problem hiding this comment.
This feature isn't supported yet and an issue will be filed shortly
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Contributor
|
Samples tests passed! 🥳 |
tswast
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕