Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore: reduce number of versions notebooks are tested on#1353

Merged
tswast merged 2 commits intomainfrom
notebook-tests
Feb 3, 2025
Merged

chore: reduce number of versions notebooks are tested on#1353
tswast merged 2 commits intomainfrom
notebook-tests

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Feb 3, 2025

These tests frequently encounter quota issues. Reducing the number of versions we test with should help alleviate this. IMO, the most important versions to test with are the ones for Google's hosted notebook environments.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast
chore: reduce number of versions notebooks are tested on
812465c 
These tests frequently encounter quota issues. Reducing the number
of versions we test with should help alleviate this. IMO, the
most important versions to test with are the ones for Google's
hosted notebook environments.
@tswast tswast requested review from a team and jialuoo February 3, 2025 16:57
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 3, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 3, 2025
@tswast tswast mentioned this pull request Feb 3, 2025
Merged
4 tasks
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Feb 3, 2025

There was still a notebook failure:

zmq.error.ZMQError: Address already in use (addr='tcp://127.0.0.1:54233')
------------------------------ Captured log call -------------------------------
ERROR    traitlets:client.py:568 Error occurred while starting new kernel client for kernel bc70ae65-583e-42d1-b157-f1ddaf7f3bc8: Kernel died before replying to kernel_info

Learn more about nbmake at [https://github.com/treebeardtech/nbmake](https://www.google.com/url?q=https://github.com/treebeardtech/nbmake&sa=D)

============================== slowest durations ===============================
3.17s call     notebooks/location/regionalized.ipynb::regionalized.ipynb

(2 durations < 0.005s hidden.  Use -vv to show these durations.)
=========================== short test summary info ============================
FAILED notebooks/location/regionalized.ipynb::regionalized.ipynb - NBMAKE INTERNAL ERROR
============================== 1 failed in 3.38s ===============================

This time, not related to AI quotas, so perhaps it's still helping in that regard.

@tswast tswast enabled auto-merge (squash) February 3, 2025 18:56
@tswast tswast merged commit 5f18add into main Feb 3, 2025
@tswast tswast deleted the notebook-tests branch February 3, 2025 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jialuoo jialuoo Awaiting requested review from jialuoo

2 more reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@shobsi shobsi shobsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GarrettWu GarrettWu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @GarrettWu @shobsi