Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore: Enable REP for latest supported regions b/375100286#1115

Merged
jialuoo merged 2 commits intomainfrom
rep
Oct 28, 2024
Merged

chore: Enable REP for latest supported regions b/375100286#1115
jialuoo merged 2 commits intomainfrom
rep

Conversation

@jialuoo
Copy link
Copy Markdown
Contributor

@jialuoo jialuoo commented Oct 25, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jialuoo jialuoo requested review from a team and sycai October 25, 2024 18:12
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 25, 2024
@jialuoo jialuoo requested a review from shobsi October 25, 2024 18:12
@jialuoo jialuoo merged commit 5528b4d into main Oct 28, 2024
@jialuoo jialuoo deleted the rep branch October 28, 2024 16:44
shobsi
shobsi reviewed Oct 29, 2024
View reviewed changes
Comment thread bigframes/constants.py
"europe-west9",
"europe-west8",
"me-central2",
"us-central1",
Copy link
Copy Markdown
Contributor

@shobsi shobsi Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed reviewing this earlier, we need to also update the API documentation https://cloud.google.com/python/docs/reference/bigframes/latest/bigframes._config.bigquery_options.BigQueryOptions#bigframes__config_bigquery_options_BigQueryOptions_use_regional_endpoints

Copy link
Copy Markdown
Contributor Author

@jialuoo jialuoo Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. Let me use another PR to fix it.

@jialuoo jialuoo mentioned this pull request Oct 29, 2024
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@shobsi shobsi shobsi left review comments

@sycai sycai sycai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TrevorBergeron TrevorBergeron

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jialuoo @shobsi @sycai @TrevorBergeron