Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: show possible correct key(s) in .__getitem__ KeyError message#1097

Merged
tswast merged 6 commits intomainfrom
b328113227-groupby-getitme-cloumn-name-error
Oct 23, 2024
Merged

feat: show possible correct key(s) in .__getitem__ KeyError message#1097
tswast merged 6 commits intomainfrom
b328113227-groupby-getitme-cloumn-name-error

Conversation

@arwas11
Copy link
Copy Markdown
Contributor

@arwas11 arwas11 commented Oct 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #328113227 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 21, 2024
@arwas11 arwas11 requested a review from tswast October 21, 2024 21:04
tswast
tswast reviewed Oct 22, 2024
View reviewed changes
Comment thread bigframes/core/groupby/__init__.py Outdated
tswast
tswast reviewed Oct 22, 2024
View reviewed changes
Comment thread tests/system/small/test_groupby.py
@arwas11 arwas11 requested a review from tswast October 23, 2024 15:56
@arwas11 arwas11 marked this pull request as ready for review October 23, 2024 15:58
@arwas11 arwas11 requested review from a team October 23, 2024 15:58
tswast
tswast approved these changes Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2024
@tswast tswast enabled auto-merge (squash) October 23, 2024 16:48
@tswast tswast merged commit 32fab96 into main Oct 23, 2024
@tswast tswast deleted the b328113227-groupby-getitme-cloumn-name-error branch October 23, 2024 16:58
@release-please release-please bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tswast tswast tswast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rey-esp rey-esp

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arwas11 @tswast @rey-esp