Skip to content

#827: Use short form imports in pubsub docs#844

Merged
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:827-pubsub_docs_short_form_imports
Apr 29, 2015
Merged

#827: Use short form imports in pubsub docs#844
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:827-pubsub_docs_short_form_imports

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Apr 29, 2015

Uses #847 as a base.

Per #827.

@jgeewax, PTAL (particuarly at 4e1d2c9).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2015
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Apr 29, 2015

Does this have another PR as a diffbase?

Overall LGTM.

I noticed you added a forgotten method to pubsub-usage. Any reason we don't just use the Sphinx autodoc features so we don't have to worry about stuff like that?

Comment thread docs/pubsub-usage.rst

This comment was marked as spam.

This comment was marked as spam.

@jgeewax
Copy link
Copy Markdown
Contributor

jgeewax commented Apr 29, 2015

LGTM

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Apr 29, 2015

Does this have another PR as a diffbase?

#847 (the original description says so.

Overall LGTM.

I noticed you added a forgotten method to pubsub-usage. Any reason we don't just use the Sphinx
autodoc features so we don't have to worry about stuff like that?

This isn't API reference documentation -- it is "common pattern" / usage docs.

tseaver added a commit that referenced this pull request Apr 29, 2015
@tseaver tseaver merged commit d21bc3f into googleapis:master Apr 29, 2015
@tseaver tseaver deleted the 827-pubsub_docs_short_form_imports branch April 29, 2015 19:57
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e59bf11 on tseaver:827-pubsub_docs_short_form_imports into 9568703 on GoogleCloudPlatform:master.

parthea pushed a commit that referenced this pull request Aug 21, 2025
* build: use multiScm for Kokoro release builds

Source-Link: googleapis/synthtool@0da1658
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5cddfe2fb5019bbf78335bc55f15bc13e18354a56b3ff46e1834f8e540807f05

* add constraints file for python 3.13

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Linchin <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
* build: use multiScm for Kokoro release builds

Source-Link: googleapis/synthtool@0da1658
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5cddfe2fb5019bbf78335bc55f15bc13e18354a56b3ff46e1834f8e540807f05

* add constraints file for python 3.13

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Linchin <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
…844)

Source-Link: googleapis/synthtool@395d53a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@16790a3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:543e209e7c1c1ffe720eb4db1a3f045a75099304fb19aa11a47dc717b8aae2a9

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
* fix: pin mock version to 5.0.0 in noxfile for unit tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* replace mock in owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* replace mock in owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update owlbot.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Mar 6, 2026
* fix: move version module to

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
…ads as a preview feature (#844)

* checkpoint before design doc impl

* checkpoint

* more tests

* code and tests for transfer manager complete

* proactively close temp files when finished reading

* respond to comments; destroy tmp files as they are consumed

* Add system tests, docstrings, address feedback

* Respond to review comments

* verify md5 hash of downloaded file in test

* lint

* default empty strings for root arguments

* fix bug with blob constructor

* add warning about files not being deleted if their downloads fail
parthea pushed a commit that referenced this pull request Mar 9, 2026
…d downloads as a preview feature (#844)" (#897)

This reverts commit 9dcc6846b52e460bee8d725099abd4dc734fa7ad.
parthea pushed a commit that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants