Skip to content

Conversation

@unknwon
Copy link
Member

@unknwon unknwon commented Jun 4, 2022

Describe the pull request

It does not make sense to proceed for either UpdatePatch or PushToBaseRepo if the head repository is missing. Previously was only checked for UpdatePatch, which would still cause panic for calls to PushToBaseRepo.

Link to the issue: #6963

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@unknwon unknwon added this to the 0.12.9 milestone Jun 4, 2022
@unknwon unknwon requested a review from a team June 4, 2022 03:02
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #7004 (f096df7) into main (75e1044) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #7004   +/-   ##
=====================================
  Coverage   8.91%   8.91%           
=====================================
  Files         99      99           
  Lines      13280   13280           
=====================================
  Hits        1184    1184           
  Misses     11930   11930           
  Partials     166     166           

@unknwon unknwon merged commit 6982749 into main Jun 4, 2022
@unknwon unknwon deleted the jc/pr-check-panic branch June 4, 2022 05:10
unknwon added a commit that referenced this pull request Jun 7, 2022
dna2github pushed a commit to dna2fork/gogs that referenced this pull request May 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants