git: worktree, implement core.filemode. Fixes #771 #1712
+296
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to implement the
core.filemodeand fix the issue 771, which addresses compatibility issues of go-git on Windows.C git implements
core.filemodein two ways:trust_executable_bit, which derives fromcore.filemodeI've tried to align the implementation with how C git handles
core.filemodeto ensure consistency:PlainInit/PlainClonewill detect and set the value ofcore.filemodein.git/configcore.filemode(trustExecutableBit) only takes effect during hash comparison. When an index entry is anexecutable and
trustExecutableBitis false, a mode value of 0644 will be used for hashing purposes—while the actual mode stored in the index remains unchanged.