Add support for storage options to PlainOpenWithOptions #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom storage options to the PlainOpenOptions struct, allowing users to pass filesystem storage options when opening repositories using PlainOpenWithOptions(). This eliminates the need to replicate PlainOpen functionality just to pass custom storage configurations like KeepDescriptors: true.
- Added
StorageOptionsfield toPlainOpenOptionsstruct - Updated
PlainOpenWithOptionsto useNewStorageWithOptionsinstead ofNewStorage - Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| options.go | Added StorageOptions field to PlainOpenOptions struct and imported filesystem package |
| repository.go | Modified PlainOpenWithOptions to use NewStorageWithOptions with the new storage options |
| repository_test.go | Added test case to verify storage options are properly passed through |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to support custom storage options when opening repo using
git.PlainOpenWithOptions()Would alleviate idiosyncracies like this one - having to replicate
git.PlainOpen()logic just to passKeepDescriptors: true:https://github.com/sourcegraph/zoekt/blob/e1cef6f2b4dc40a2075839273a729c26f9a61c27/gitindex/index.go#L588-L591