Skip to content
This repository was archived by the owner on Jan 31, 2019. It is now read-only.

Fix Asana exceptions when parsing non-existent Asana task IDs #854

Merged
atmos merged 5 commits into from
May 14, 2014
Merged

Fix Asana exceptions when parsing non-existent Asana task IDs #854

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be21d8d
Flatten task list for simpler access to matches
jdpace May 14, 2014
cdfa5d3
Refactor Asana service to use standard Ruby interpolation
jdpace May 14, 2014
1497cdd
Ignore 400 responses for unknown tasks from Asana.
jdpace May 14, 2014
cb41edc
Pull error messages from JSON response
jdpace May 14, 2014
a7811da
Handle cases where Asana crashes without JSON error
jdpace May 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Flatten task list for simpler access to matches
  • Loading branch information
@jdpace
jdpace committed May 14, 2014
commit be21d8d3efb7c86f35d168ddd30b906631cdbe64
4 changes: 2 additions & 2 deletions lib/services/asana.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ def check_commit(commit, push_msg)
end

# post commit to every taskid found
task_list.each do |taskid|
task_list.flatten.each do |taskid|

http.basic_auth(data['auth_token'], "")
http.headers['X-GitHub-Event'] = event.to_s

res = http_post "https://app.asana.com/api/1.0/tasks/" + taskid[0] + "/stories", "text=" + push_msg + message
res = http_post "https://app.asana.com/api/1.0/tasks/" + taskid + "/stories", "text=" + push_msg + message
if res.status < 200 || res.status > 299
raise_config_error res.message
end
Expand Down