Fix [reference-impl-hash] parameter naming in update-changelog.sh#76
Closed
Fix [reference-impl-hash] parameter naming in update-changelog.sh#76
Conversation
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/dc42a537-067a-4251-bd14-0fb8fede94d9 Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comments
Fix [reference-impl-hash] parameter naming in update-changelog.sh
Apr 16, 2026
Collaborator
|
I copied this commit over to the topic branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update-changelog.shscript used[upstream-hash]as the optional parameter name in usage text — inconsistent with the reference-impl terminology used elsewhere and awkward as a CLI arg placeholder.Changes
.github/scripts/release/update-changelog.sh: replaced[upstream-hash]with[reference-impl-hash]in the header comment and the runtime usage error messageBefore the change?
./update-changelog.sh <version> [upstream-hash]After the change?
./update-changelog.sh <version> [reference-impl-hash]Pull request checklist
mvn spotless:applyhas been run to format the codemvn clean verifypasses locallyDoes this introduce a breaking change?