Skip to content

fix(pydantic-ai): Do not fail on new ToolManager._call_tool() parameters #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 11, 2025
Merged

fix(pydantic-ai): Do not fail on new ToolManager._call_tool() parameters #5084

merged 24 commits into from
Nov 11, 2025
+10 −14

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Nov 7, 2025 •
edited
Loading

Description

See changes to pydantic_ai_slim/pydantic_ai/_tool_manager.py introduced in pydantic/pydantic-ai@930d74c.

Because ToolManager._call_tool now accepts a new parameter, our instrumentation breaks.

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb changed the title [do not merge]: generate tox fix(pydantic-ai): Do not fail on new ToolManager._call_tool() parameters Nov 7, 2025
@alexander-alderman-webb alexander-alderman-webb changed the title fix(pydantic-ai): Do not fail on new ToolManager._call_tool() parameters fix(pydantic-ai): Do not fail on new ToolManager._call_tool() parameters Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.95%. Comparing base (6b76b44) to head (b5647e0).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ntry_sdk/integrations/pydantic_ai/patches/tools.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           webb/run-ci    #5084      +/-   ##
===============================================
- Coverage        83.96%   83.95%   -0.02%     
===============================================
  Files              179      179              
  Lines            17951    17951              
  Branches          3194     3194              
===============================================
- Hits             15073    15071       -2     
- Misses            1906     1908       +2     
  Partials           972      972
Files with missing lines Coverage Δ
...ntry_sdk/integrations/pydantic_ai/patches/tools.py 78.94% <66.66%> (ø)

... and 2 files with indirect coverage changes

@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Nov 7, 2025
Open
@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Nov 10, 2025
Merged
Base automatically changed from webb/run-ci to master November 11, 2025 08:33
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 11, 2025 08:40
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 11, 2025 08:40
sentrivana
sentrivana approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@alexander-alderman-webb alexander-alderman-webb merged commit 98fa10a into master Nov 11, 2025
129 of 130 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/pydantic-ai-fix branch November 11, 2025 08:54
@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Nov 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-alderman-webb @sentrivana