Bugfix: Enhance OptionParser to check for array indices before access… #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing them, preventing potential undefined index errors.
There was a problem hiding this comment.
Pull Request Overview
This PR adds defensive isset() checks before accessing optional array elements at indices 3 and 4 in the parseArray() method to prevent potential undefined index errors.
- Added
isset($array[3])check before accessing the description element - Added
isset($array[4])check before accessing the default value element
Comments suppressed due to low confidence (1)
src/OptionParser.php:74
- The
$rowSizevariable is calculated before potentially modifying$arrayon line 73. When$rowSize < 3, the array is replaced with a 3-element array fromcompleteOptionArray(), but$rowSizeretains the original count. This creates a logical inconsistency where lines 78 and 82 check$rowSize >= 4and$rowSize >= 5but$arraymay only have 3 elements. Consider recalculating$rowSizeafter line 73:$rowSize = count($array);
$rowSize = count($array);
if ($rowSize < 3) {
$array = self::completeOptionArray($array);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Oh wow, didn't know google is using this lib 🙂 So google is using it wrong or is that a regression? Something that worked in 3.x does not work in 4.0? Can you maybe create a Test to demonstrate what got fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing them, preventing potential undefined index errors.
tumbled over this while installing Google Ads Client https://github.com/googleads/google-ads-php
but using getOpt 4.0,4 insted of 3.4 (due to PHP 8.3)