[various] Use RadioGroup for groupValue and onChanged #9467
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for the contribution! Marking as a draft for now since this will require min SDK updates, and that can't be done in the PR until the next stable has shipped. |
|
It should be possible to update this to be landable now that 3.35 has shipped to stable. |
c440084 to
f3ed535
Compare
|
From triage: @Phantom-101 Are you still planning on updating this PR to resolve the CI failures? |
|
Sorry for the delay, I am currently busy with some other work so it may be a while before I update this. |
Use RadioGroup to avoid deprecated
groupValueandonChanged(flutter/flutter#170915)Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].///).