[camera_android_camerax] Fixes crash with unsupported operation exception #10342
+113
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash in `DeviceOrientationManager` that occurred when `getDisplay()` was called on a null or destroyed Activity during device rotation. This was caused by an `UnsupportedOperationException`.
camsim99
reviewed
Nov 3, 2025
Contributor
camsim99
left a comment
There was a problem hiding this comment.
The change looks good to me overall. Thanks for the quick fix! But I do want to discuss the check added to getDisplay.
...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java
Outdated
Show resolved
Hide resolved
...mera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/ProxyApiRegistrar.java
Outdated
Show resolved
Hide resolved
Fixed a crash in DeviceOrientationManager related to Activity state during rotation.
Contributor
|
autosubmit label was removed for flutter/packages/10342, because - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash in
DeviceOrientationManagercaused byUnsupportedOperationExceptionwhengetDisplay()is called on a null or destroyed Activity during rotation.Fixes flutter/flutter#176613
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3