fix partial_shuffle in distinct_count_test#6026
Merged
ryzhyk merged 1 commit intofeldera:mainfrom Apr 13, 2026
Merged
Conversation
Signed-off-by: Daniel Philip Watson <danielwatson311@gmail.com>
mythical-fred
suggested changes
Apr 13, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
$One blocker: please rewrite the commit subject in proper imperative form before merge. fix partial_shuffle in distinct_count_test should be something like Fix partial_shuffle in distinct_count_test. Git history is a first-class artifact, and even tiny test fixes should keep clean commit subjects.
Contributor
|
@mythical-fred the commit message is fine @TheIronBorn do you mind sharing the rationale for the change? it looks fine but just trying to understand the reason edit: NVM I saw your paragraph at the end of the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
Checklist
- [ ] Integration tests added/updated(N/A)- [ ] Documentation updated(N/A)- [ ] Changelog updated(N/A)Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
N/A
partial_shuffleactually currently puts the shuffled elements at the end of the original slice, but the more robust solution is to use the slices returned by the function directly. (partial_shuffledocs here)