Skip to content

ci: abort Docker build job when workflow is cancelled#6024

Merged
gz merged 1 commit intomainfrom
fix-docker-cancel
Apr 12, 2026
Merged

ci: abort Docker build job when workflow is cancelled#6024
gz merged 1 commit intomainfrom
fix-docker-cancel

Conversation

@jyotshnayaparla-00
Copy link
Copy Markdown
Contributor

Remove always() and the result == 'skipped' conditions from invoke-build-docker.

This is the same issue fixed for invoke-tests-web-console-e2e. The always() condition was added to allow Docker to build even when upstream jobs were "skipped", a scenario that only existed with the artifact-caching feature reverted in #5974. Without that feature, Rust/Java builds are never legitimately skipped, so always() causes Docker to keep running when the workflow is cancelled (upstream jobs get cancelled → skipped → Docker condition evaluates true).

Removing the if: entirely means Docker only builds when all upstream jobs actually succeed, and aborts with the rest of the workflow on cancellation.

@jyotshnayaparla-00 jyotshnayaparla-00 self-assigned this Apr 12, 2026
@jyotshnayaparla-00 jyotshnayaparla-00 requested a review from gz April 12, 2026 16:13
Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gz gz added this pull request to the merge queue Apr 12, 2026
Merged via the queue into main with commit ec739d9 Apr 12, 2026
1 check passed
@gz gz deleted the fix-docker-cancel branch April 12, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants