Skip to content

[SQL] Fix crash in waterline computation#6019

Merged
mihaibudiu merged 1 commit intofeldera:mainfrom
mihaibudiu:lateness-bug
Apr 12, 2026
Merged

[SQL] Fix crash in waterline computation#6019
mihaibudiu merged 1 commit intofeldera:mainfrom
mihaibudiu:lateness-bug

Conversation

@mihaibudiu
Copy link
Copy Markdown
Contributor

@mihaibudiu mihaibudiu commented Apr 11, 2026

Reported by a customer.

This crash is caused by the monotone field analysis not expecting that some of the input fields of a join are not used. This used to be true, but the optimization to share indexes between joins makes this assumption false.

Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu mihaibudiu requested a review from gz April 11, 2026 13:42
@mihaibudiu mihaibudiu enabled auto-merge April 11, 2026 14:12
@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 11, 2026
@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2026
@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 12, 2026
Merged via the queue into feldera:main with commit dbb8fba Apr 12, 2026
1 check passed
@mihaibudiu mihaibudiu deleted the lateness-bug branch April 12, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants