Fix f64 deserialization in DevTweaks inside flattened PipelineConfig#6017
Merged
Fix f64 deserialization in DevTweaks inside flattened PipelineConfig#6017
Conversation
…eConfig DevTweaks Option<f64> fields (bloom_false_positive_rate, balancer_balance_tax, etc.) fail to deserialize when nested inside PipelineConfig, which uses triggered by the workspace-wide arbitrary_precision feature: the Content buffer represents numbers as maps, producing "invalid type: map, expected f64". Apply the existing serde_via_value::deserialize workaround (already used by ResourceConfig.cpu_cores_min/max) to all four Option<f64> fields in DevTweaks. Also add the chrono "alloc" feature to fix a pre-existing compile error in adapter_stats.rs (to_rfc3339_opts returns String, which requires alloc). Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
abhizer
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevTweaks Option fields (bloom_false_positive_rate, balancer_balance_tax, etc.) fail to deserialize when nested inside PipelineConfig, which uses #[serde(flatten)] on RuntimeConfig.
This is a known serde_json bug (#1157) triggered by the workspace-wide arbitrary_precision feature: the Content buffer represents numbers as maps, producing "invalid type: map, expected f64".
Apply the existing serde_via_value::deserialize workaround (already used by ResourceConfig.cpu_cores_min/max) to all four Option fields in DevTweaks.
Describe Manual Test Plan
Checklist
Breaking Changes?
This fixes a breaking regression introduced in v0.277.