Skip to content

feat: Add 'send-money' and 'receive-money' and 'dashboard' icons #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dbedoyat wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add 'send-money' and 'receive-money' and 'dashboard' icons #714

dbedoyat wants to merge 4 commits into from

Conversation

@dbedoyat
Copy link

@dbedoyat dbedoyat commented Aug 8, 2019

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2019 •
edited
Loading

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #714   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5047ddb...0884d0f. Read the comment docs.

moeenio
moeenio suggested changes Aug 8, 2019
View reviewed changes
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fills are allowed.

@dbedoyat dbedoyat changed the title feat: Add 'send-money' and 'receive-money' icons feat: Add 'send-money' and 'receive-money' and 'dashboard' icons Aug 8, 2019
@moeenio
Copy link

moeenio commented Aug 8, 2019

Please read my review

@dbedoyat
Copy link
Author

dbedoyat commented Aug 8, 2019

Please read my review

Fixed! @locness3

moeenio
moeenio previously approved these changes Aug 10, 2019
View reviewed changes
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe conforming with the banknote icon submitted here #670 ? Also you should remove the class names in dashboard ?

@moeenio
Copy link

moeenio commented Aug 10, 2019

Didn't want to approve

@dbedoyat
Copy link
Author

dbedoyat commented Aug 10, 2019

Maybe conforming with the banknote icon submitted here #670 ? Also you should remove the class names in dashboard ?

Yep, i remove the class names in 'dashboard'.

moeenio
moeenio reviewed Aug 11, 2019
View reviewed changes
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe conforming with the banknote icon in #670 ?

@dbedoyat
Copy link
Author

dbedoyat commented Aug 11, 2019

Maybe conforming with the banknote icon in #670 ?

According to your feedback the icon 'Banknote' has a fill in the circles.

Will you need to do similar like #670 ?

@moeenio
Copy link

moeenio commented Aug 12, 2019

According to your feedback the icon 'Banknote' has a fill in the circles.

In #670 ? It doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moeenio moeenio moeenio left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dbedoyat @moeenio