Skip to content

Conversation

@ashygee
Copy link
Collaborator

@ashygee ashygee commented Jan 26, 2019

screenshot 2019-01-26 14 47 23

Suggesting to add a pen tool icon to collection.

Request review @colebemis.

@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #522   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1fca0...d6d2898. Read the comment docs.

@colebemis
Copy link
Member

Looks good! I usually try to avoid using the "dot" if I can help it. What do you think of these options? Do you have a preference?
image

@ashygee
Copy link
Collaborator Author

ashygee commented Jan 28, 2019

@colebemis i like the first version you made. What would that look like with the nib widened a bit?

@colebemis
Copy link
Member

Which one do you like?
image

@ashygee
Copy link
Collaborator Author

ashygee commented Jan 28, 2019

@colebemis I think for Feather the first is the best choice. It keeps the angles and simplicity of the other icons.

@colebemis
Copy link
Member

Sweet. Let's roll with that one. The icon is in the Figma doc 👍

@ashygee ashygee requested a review from colebemis January 29, 2019 04:12
@ashygee
Copy link
Collaborator Author

ashygee commented Jan 29, 2019

Updated with the new version. Ready for review @colebemis!

Co-Authored-By: ashygee <10384315+ashygee@users.noreply.github.com>
Copy link
Member

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great addition! Thanks 🎉

@colebemis colebemis merged commit 0a130b7 into master Jan 29, 2019
@colebemis colebemis deleted the add-pentool branch January 29, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants