fix: Add get_table_query_string_with_alias() for PostgreSQL subquery aliasing #5811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2b0824 to
b144441
Compare
…aliasing PostgreSQL requires all subqueries in FROM clauses to have aliases. This adds a new method get_table_query_string_with_alias() to PostgreSQLSource that automatically adds an alias when the source is query-based. The existing get_table_query_string() is preserved for backward compatibility and updated with documentation explaining when to use the new method. Fixes feast-dev#5605 Signed-off-by: Yassin Nouh <yassinmnouh@gmail.com> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
b144441 to
994a632
Compare
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Contributor
Author
|
@franciscojavierarceo can u take a look into this ? |
franciscojavierarceo
approved these changes
Jan 9, 2026
Member
franciscojavierarceo
left a comment
There was a problem hiding this comment.
nice, it'd be good to have this run an integration test for it but it's fine.
YassinNouh21
added a commit
to YassinNouh21/feast
that referenced
this pull request
Jan 10, 2026
…aliasing (feast-dev#5811) Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_table_query_string_with_alias()method toPostgreSQLSourceclassget_table_query_string()returns unaliased subqueriesget_table_query_string()unchangedTest Plan
get_table_query_string_with_alias()methodFixes #5605