Skip to content

fix(redis): Preserve millisecond timestamp precision for Redis online store #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Jan 6, 2026
Merged

fix(redis): Preserve millisecond timestamp precision for Redis online store #5807

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f26c62
Update redis.py
jatin5251 Jan 1, 2026
828da5b
Update redis.py
jatin5251 Jan 1, 2026
a7dca65
Update redis.py
jatin5251 Jan 1, 2026
547ca7d
Merge branch 'master' into redis-ms-timestamp
jatin5251 Jan 2, 2026
2fded63
Merge branch 'master' into redis-ms-timestamp
jatin5251 Jan 6, 2026
ea3be27
Update redis.py
jatin5251 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions sdk/python/feast/infra/online_stores/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,22 +304,25 @@ def online_write_batch(
for redis_key_bin, prev_event_time, (_, values, timestamp, _) in zip(
keys, prev_event_timestamps, data
):
event_time_seconds = int(utils.make_tzaware(timestamp).timestamp())

# ignore if event_timestamp is before the event features that are currently in the feature store
# Convert incoming timestamp to millisecond-aware datetime
aware_ts = utils.make_tzaware(timestamp)
# Build protobuf timestamp with nanos
ts = Timestamp()
ts.FromDatetime(aware_ts)
# New timestamp in nanoseconds
new_total_nanos = ts.seconds * 1_000_000_000 + ts.nanos
# Compare against existing timestamp (nanosecond precision)
if prev_event_time:
prev_ts = Timestamp()
prev_ts.ParseFromString(prev_event_time)
if prev_ts.seconds and event_time_seconds <= prev_ts.seconds:
# TODO: somehow signal that it's not overwriting the current record?
prev_total_nanos = prev_ts.seconds * 1_000_000_000 + prev_ts.nanos
# Skip only if older OR exact same instant
if prev_total_nanos and new_total_nanos <= prev_total_nanos:
if progress:
progress(1)
continue

ts = Timestamp()
ts.seconds = event_time_seconds
entity_hset = dict()
entity_hset[ts_key] = ts.SerializeToString()
# Store full timestamp (seconds + nanos)
entity_hset = {ts_key: ts.SerializeToString()}

for feature_name, val in values.items():
f_key = _mmh3(f"{feature_view}:{feature_name}")
Expand Down Expand Up @@ -456,5 +459,7 @@ def _get_features_for_entity(
if not res:
return None, None
else:
timestamp = datetime.fromtimestamp(res_ts.seconds, tz=timezone.utc)
# reconstruct full timestamp including nanos
total_seconds = res_ts.seconds + res_ts.nanos / 1_000_000_000.0
timestamp = datetime.fromtimestamp(total_seconds, tz=timezone.utc)
return timestamp, res
Loading